Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite simd128 and wasm support #620

Merged
merged 1 commit into from
Dec 14, 2018
Merged

Rewrite simd128 and wasm support #620

merged 1 commit into from
Dec 14, 2018

Conversation

alexcrichton
Copy link
Member

  • Update representation of v128
  • Rename everything with new naming convention of underscores and no
    modules/impls
  • Remove no longer necessary wasm_simd128 feature
  • Remove #[target_feature] attributes (use #[cfg] instead)
  • Update assert_instr tests
  • Update some implementations as LLVM has evolved
  • Allow some more esoteric syntax in #[assert_instr]
  • Adjust the safety of APIs where appropriate
  • Remove macros in favor of hand-coded implementations
  • Comment out the tests for now as there's no known runtime for these
    yet

@alexcrichton alexcrichton mentioned this pull request Dec 13, 2018
Closed
@alexcrichton
Rewrite simd128 and wasm support
6505e80 
* Update representation of `v128`
* Rename everything with new naming convention of underscores and no
  modules/impls
* Remove no longer necessary `wasm_simd128` feature
* Remove `#[target_feature]` attributes (use `#[cfg]` instead)
* Update `assert_instr` tests
* Update some implementations as LLVM has evolved
* Allow some more esoteric syntax in `#[assert_instr]`
* Adjust the safety of APIs where appropriate
* Remove macros in favor of hand-coded implementations
* Comment out the tests for now as there's no known runtime for these
  yet
@gnzlbg gnzlbg self-requested a review December 13, 2018 23:37
@alexcrichton alexcrichton merged commit 359b736 into rust-lang:master Dec 14, 2018
@alexcrichton alexcrichton deleted the wasm-simd-rewrite branch December 14, 2018 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnzlbg gnzlbg gnzlbg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexcrichton @gnzlbg